Skip to content

Refactor memory copies in SafeBuffer#105206

Merged
jkoritzinsky merged 4 commits intodotnet:mainfrom
xtqqczze:SafeBuffer-Memmove
Oct 15, 2024
Merged

Refactor memory copies in SafeBuffer#105206
jkoritzinsky merged 4 commits intodotnet:mainfrom
xtqqczze:SafeBuffer-Memmove

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 21, 2024 •
edited
Loading

No diffs expected, except from the changes to sign-extension.

Diffs are an improvement: MihuBot/runtime-utils#548

System.Runtime.InteropServices.SafeBuffer:Read[ubyte](ulong):ubyte:this 
 G_M48575_IG03:
-       lea      rsi, [rbp-0x20]
-       mov      rdi, gword ptr [rbp-0x28]
+       lea      rsi, [rbp-0x10]
+       mov      rdi, gword ptr [rbp-0x18]
        mov      rax, 0xD1FFAB1E      ; code for System.Runtime.InteropServices.SafeHandle:DangerousAddRef(byref):this
        call     [rax]System.Runtime.InteropServices.SafeHandle:DangerousAddRef(byref):this
-       mov      edx, r15d
-       lea      rdi, [rbp-0x18]
-       mov      rsi, rbx
-       mov      rax, 0xD1FFAB1E      ; code for System.SpanHelpers:Memmove(byref,byref,ulong)
-       call     [rax]System.SpanHelpers:Memmove(byref,byref,ulong)
-       nop      
-						;; size=43 bbWeight=1 PerfScore 9.25
+       movzx    rbx, byte  ptr [rbx]
+						;; size=23 bbWeight=1 PerfScore 6.75

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 21, 2024
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 21, 2024

@MihuBot -arm64

@MihuBot MihuBot mentioned this pull request Jul 21, 2024
Open
This was referenced Jul 22, 2024
Closed
Open
Closed
Closed
Closed
@xtqqczze xtqqczze force-pushed the SafeBuffer-Memmove branch from 1ecb4be to 60398d7 Compare July 22, 2024 17:21
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 22, 2024

@MihuBot -arm64

@MihuBot MihuBot mentioned this pull request Jul 22, 2024
Open
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 22, 2024

@MihuBot

@MihuBot MihuBot mentioned this pull request Jul 22, 2024
Open
This was referenced Jul 22, 2024
Closed
Closed
@xtqqczze xtqqczze marked this pull request as ready for review July 23, 2024 17:26
@xtqqczze xtqqczze force-pushed the SafeBuffer-Memmove branch from 60398d7 to b6797f0 Compare July 27, 2024 13:59
This was referenced Jul 27, 2024
Closed
Closed
@am11 am11 added area-System.Runtime.InteropServices and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 6, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 6, 2024

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Aug 7, 2024
Open
@xtqqczze xtqqczze force-pushed the SafeBuffer-Memmove branch from b6797f0 to 3036449 Compare August 8, 2024 15:05
@build-analysis build-analysis bot mentioned this pull request Aug 10, 2024
Closed
@agocke
Copy link
Member

agocke commented Oct 14, 2024

@tannergooding Do you want to take a look at this?

@build-analysis build-analysis bot mentioned this pull request Oct 15, 2024
Open
@jkoritzinsky jkoritzinsky merged commit 7f682ef into dotnet:main Oct 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas left review comments

@tannergooding tannergooding tannergooding approved these changes

Assignees

No one assigned

Labels

area-System.Runtime.InteropServices community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xtqqczze @agocke @jkotas @tannergooding @jkoritzinsky @am11