Implement IUtf8SpanParsable on Guid#105654
Merged
stephentoub merged 2 commits intodotnet:mainfrom Jun 1, 2025
Merged
Conversation
ghost
added
needs-area-label
|
Note regarding the |
1 similar comment
|
Note regarding the |
dotnet-policy-service
bot
added
the
community-contribution
Contributor
Author
|
@dotnet-policy-service agree |
huoyaoyuan
reviewed
Jul 30, 2024
lilinus
reviewed
Jul 30, 2024
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/GuidTests.cs
Show resolved
Hide resolved
lilinus
reviewed
Jul 30, 2024
This was referenced Jul 30, 2024
lilinus
reviewed
Jul 31, 2024
lilinus
reviewed
Jul 31, 2024
huoyaoyuan
added
area-System.Runtime
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Open
3 tasks
stephentoub
reviewed
May 28, 2025
stephentoub
reviewed
May 28, 2025
stephentoub
reviewed
May 28, 2025
stephentoub
reviewed
May 28, 2025
stephentoub
approved these changes
May 28, 2025
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Other than my comments/questions, LGTM. Thanks.
stephentoub
force-pushed
the
GuidIUtf8Parseable
branch
from
58f51af to
81820ce
Compare
Contributor
Author
|
Just saw the updates, sorry for not responding quicker. Glad to see this merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #81500
API Proposal: #105653
This implements
IUtf8SpanParsableonGuidby making the core of the parsing logic generic onTChar : IUtfChar<TChar>. A small amount of it is duplicated, with a version forcharandbyte, because doing so prevented a performance regression forcharparsing.In addition, it adds a Utf8
ParseandTryParsewithout the unusedIFormatProviderparameter, to match howISpanParsablewas implemented. I did not add Utf8 overloads forParseExact, but that can be discussed in the linked API proposal.