JIT: Skip cost improvement check in 3-opt for exceptionally costly layouts#110069
Merged
amanasifkhalid merged 3 commits intodotnet:mainfrom Nov 22, 2024
Merged
JIT: Skip cost improvement check in 3-opt for exceptionally costly layouts#110069amanasifkhalid merged 3 commits intodotnet:mainfrom
amanasifkhalid merged 3 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
src/coreclr/jit/fgopt.cpp
Outdated
| // | ||
| // Returns: | ||
| // The region's layout cost | ||
| // The region's layout cost, or 'BB_MAX_WEIGHT' for pathalogically costly layouts |
Contributor
There was a problem hiding this comment.
Suggested change
| // The region's layout cost, or 'BB_MAX_WEIGHT' for pathalogically costly layouts | |
| // The region's layout cost, or 'BB_MAX_WEIGHT' for pathologically costly layouts |
Contributor
Author
|
/azp run runtime-coreclr libraries-jitstress, Antigen |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
amanasifkhalid
changed the title
Contributor
Author
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. |
Open
3 tasks
AndyAyersMS
approved these changes
Nov 22, 2024
Contributor
Author
|
/ba-g Linux-arm64 NativeAOT build timed out. |
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109984.