JIT: generalize ParseArrayAddress a bit more#112527
Merged
AndyAyersMS merged 2 commits intodotnet:mainfrom Feb 13, 2025
Merged
Conversation
Now that we are stack allocating arrays, the array reference may be either TYP_BYREF or TYP_I_IMPL, so try and recognize those cases when possible. In particular for OSR methods the array allocation may "disappear" once we redirect flow to the OSR entry, so relying on VN is insufficient. Fixes dotnet#112429 (benchmark regression where we're measuring OSR code)
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
@EgorBo PTAL Would be nice not to have to have |
jakobbotsch
reviewed
Feb 13, 2025
src/coreclr/jit/gentree.cpp
Outdated
Comment on lines
+19904
to
+19905
| const unsigned lclNum = tree->AsLclVar()->GetLclNum(); | ||
| CORINFO_CLASS_HANDLE hnd = comp->lvaTable[lclNum].lvClassHnd; |
Member
There was a problem hiding this comment.
Suggested change
| const unsigned lclNum = tree->AsLclVar()->GetLclNum(); | |
| CORINFO_CLASS_HANDLE hnd = comp->lvaTable[lclNum].lvClassHnd; | |
| CORINFO_CLASS_HANDLE hnd = comp->lvaGetDesc(tree->AsLclVar())->lvClassHnd; |
Member
There was a problem hiding this comment.
(mostly just want to see lvaGetDesc instead of raw access into lvaTable)
jakobbotsch
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are stack allocating arrays, the array reference may be either TYP_BYREF or TYP_I_IMPL, so try and recognize those cases when possible. In particular for OSR methods the array allocation may "disappear" once we redirect flow to the OSR entry, so relying on VN is insufficient.
Fixes #112429 (benchmark regression where we're measuring OSR code)