Allow publishing AndroidSampleApp with R2R using in-build crossgen2#112547
Merged
elinor-fung merged 6 commits intodotnet:mainfrom Feb 18, 2025
Merged
Allow publishing AndroidSampleApp with R2R using in-build crossgen2#112547elinor-fung merged 6 commits intodotnet:mainfrom
elinor-fung merged 6 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- src/libraries/externals.csproj: Language not supported
- src/mono/sample/Android/AndroidSampleApp.csproj: Language not supported
- src/mono/sample/Android/AndroidSampleApp.targets: Language not supported
ghost
added
the
elinor-fung
added
os-android
area-Infrastructure-mono
and removed
area-Infrastructure-mono
labels
Contributor
|
Tagging subscribers to this area: @akoeplinger, @matouskozak |
steveisok
approved these changes
Feb 14, 2025
This was referenced Feb 14, 2025
Closed
ivanpovazan
reviewed
Feb 14, 2025
elinor-fung
commented
Feb 14, 2025
elinor-fung
commented
Feb 14, 2025
This was referenced Feb 15, 2025
ivanpovazan
approved these changes
Feb 17, 2025
Member
ivanpovazan
left a comment
ivanpovazan
left a comment
There was a problem hiding this comment.
LGTM, thanks!
PS: The CoreCLR on Android failure is not related to this PR, I opened a tracking issue for it: #112633
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the in-build crossgen2 to publish
AndroidSampleAppifPublishReadyToRunis set totrue. I left it off in the project, but it can now be enabled. Also removecorerunfrom the Android local runtime pack.HelloAndroid.apk size:
No R2R: 7.8 MB
R2R: 9.4 MB
R2R composite: 9.5 MB