Avoid some redundant casts in DefaultInterpolatedStringHandler.AppendFormatted#114664
Closed
SimonCropp wants to merge 3 commits intodotnet:mainfrom
SimonCropp:Avoid-some-redundant-casts-in-DefaultInterpolatedStringHandler.AppendFormatted
Closed
Avoid some redundant casts in DefaultInterpolatedStringHandler.AppendFormatted#114664SimonCropp wants to merge 3 commits intodotnet:mainfrom SimonCropp:Avoid-some-redundant-casts-in-DefaultInterpolatedStringHandler.AppendFormatted
SimonCropp wants to merge 3 commits intodotnet:mainfrom
SimonCropp:Avoid-some-redundant-casts-in-DefaultInterpolatedStringHandler.AppendFormatted
Conversation
…t-casts-in-DefaultInterpolatedStringHandler.AppendFormatted
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices |
…latedStringHandler.AppendFormatted
This was referenced Apr 15, 2025
Member
|
See https://devblogs.microsoft.com/dotnet/performance-improvements-in-net-9/ and search for "One interesting case for .NET has had to do with structs and casting". It's possible the issue has been addressed enough in .NET 9 that the casting can be fixed up as in this PR, but it would need to be validated first before we could consider taking this. |
stephentoub
added
the
NO-MERGE
Contributor
Author
|
@stephentoub based on the extra context, i dont think there is enough value in this. closing, and sorry for the noise |
SimonCropp
deleted the
Avoid-some-redundant-casts-in-DefaultInterpolatedStringHandler.AppendFormatted
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is possible i am missing some edge case about how the compiler treats casts
so if this is worse for perf. i would love to know why :)