Fix Environment.UserInteractive on Windows by danmoseley · Pull Request #1234 · dotnet/runtime

danmoseley · 2020-01-01T01:39:09Z

Fix #770

src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs

src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs

...s.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestService.cs

src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs

jkotas · 2020-01-03T03:23:47Z

Build break ... LGTM otherwise.

…nteractive

src/coreclr/src/System.Private.CoreLib/System.Private.CoreLib.csproj

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems

danmoseley · 2020-01-03T22:17:38Z

All failures are from the bad ARM legs.

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs

…b.Shared.projitems Co-Authored-By: Jan Kotas <[email protected]>

…osemsft/runtime into Environment.UserInteractive

danmoseley · 2020-01-04T00:43:55Z

Any more feedback? I can't merge without dismissing your review -- not sure of the protocol

CI is fine, except for an unrelated bug I logged.

ericstj · 2020-02-27T21:08:43Z

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs

+                    uint dummy = 0;
+                    if (Interop.User32.GetUserObjectInformationW(handle, Interop.User32.UOI_FLAGS, &flags, (uint)sizeof(Interop.User32.USEROBJECTFLAGS), ref dummy))
+                    {
+                        return ((flags.dwFlags & Interop.User32.WSF_VISIBLE) == 0);


It looks like you forgot to invert this logic. Also, should we add back the static property like we had in desktop?
https://referencesource.microsoft.com/#mscorlib/system/environment.cs,1435

Ack - thank you @ericstj !

Re the static, @jkotas pointed out that there may be a way to change a process to/from interactive - although I didn't do it successfully myself. See mention here #770 (comment) I saw no reason to cache the value.

Ok, I'll make the simple fix for now. FWIW I'm now able to reproduce the test failure, so I can confirm fail/then-fix.

That would explain #1724 also. I was not albe to run the service controller tests locally because of #1262. I tested locally by hand instead, and apparently did so before I made this mistake.

Comments crossed. Great, I was about to do it, but apparently you've already got those tests working so you can verify it as well. thanks

danmoseley added 2 commits December 31, 2019 17:24

Implement Environment.UserInteractive

c5db003

typo

6bfe1f8

Dotnet-GitSync-Bot added the area-System.Runtime label Jan 1, 2020

rename

d250a1f

jkotas reviewed Jan 1, 2020

View reviewed changes

src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 1, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated Show resolved Hide resolved

jkotas reviewed Jan 1, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 1, 2020

View reviewed changes

src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 1, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs Outdated Show resolved Hide resolved

danmoseley added 3 commits January 2, 2020 10:02

Revert M.Win32.SE

85b403b

CR feedback

ebaf64c

CR feedback:

e6ea75b

danmoseley force-pushed the Environment.UserInteractive branch from 67406aa to e6ea75b Compare January 2, 2020 20:36

typo

6883f08

jkotas reviewed Jan 3, 2020

View reviewed changes

...s.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestService.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 3, 2020

View reviewed changes

src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 3, 2020

View reviewed changes

src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft/Win32/SystemEvents.cs Outdated Show resolved Hide resolved

danmoseley added 3 commits January 2, 2020 16:32

Fix test

2b0e0f4

GUOI declaration

fcc553b

Another typo!

b0e6f89

danmoseley added 2 commits January 3, 2020 10:11

Merge remote-tracking branch 'upstream/master' into Environment.UserI…

1136d92

…nteractive

Fix build break

7a7d8ff

gmatzen mentioned this pull request Jan 3, 2020

Should we revise implementation of Environment.UserInteractive? #770

Closed

jkotas reviewed Jan 3, 2020

View reviewed changes

src/coreclr/src/System.Private.CoreLib/System.Private.CoreLib.csproj Outdated Show resolved Hide resolved

jkotas reviewed Jan 3, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated Show resolved Hide resolved

jkotas reviewed Jan 3, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated Show resolved Hide resolved

jkotas reviewed Jan 3, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated Show resolved Hide resolved

jkotas reviewed Jan 3, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs Outdated Show resolved Hide resolved

danmoseley and others added 5 commits January 3, 2020 14:26

Update src/libraries/System.Private.CoreLib/src/System.Private.CoreLi…

f52a075

…b.Shared.projitems Co-Authored-By: Jan Kotas <[email protected]>

Update src/libraries/System.Private.CoreLib/src/System.Private.CoreLi…

65f5813

…b.Shared.projitems Co-Authored-By: Jan Kotas <[email protected]>

Update src/libraries/System.Private.CoreLib/src/System.Private.CoreLi…

960cbc7

…b.Shared.projitems Co-Authored-By: Jan Kotas <[email protected]>

CR feedback

444554b

Merge branch 'Environment.UserInteractive' of https://github.com/danm…

ef583c0

…osemsft/runtime into Environment.UserInteractive

danmoseley requested a review from jkotas January 4, 2020 00:43

jkotas approved these changes Jan 4, 2020

View reviewed changes

danmoseley merged commit 2c6ec17 into dotnet:master Jan 4, 2020

danmoseley deleted the Environment.UserInteractive branch January 4, 2020 07:11

ericstj mentioned this pull request Jan 15, 2020

TestOnExecuteCustomCommand fails with Assert.Equal #1724

Open

janvorli mentioned this pull request Jan 30, 2020

Expose the Unix hosting API on Windows too #4374

Closed

danmoseley mentioned this pull request Feb 27, 2020

Environment.UserInteractive can be unexpectedly false #32929

Closed

ericstj reviewed Feb 27, 2020

View reviewed changes

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Conversation

danmoseley commented Jan 1, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danmoseley commented Jan 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danmoseley commented Jan 4, 2020

Uh oh!

ericstj Feb 27, 2020

Choose a reason for hiding this comment

Uh oh!

danmoseley Feb 27, 2020

Choose a reason for hiding this comment

Uh oh!

ericstj Feb 27, 2020

Choose a reason for hiding this comment

Uh oh!

danmoseley Feb 27, 2020

Choose a reason for hiding this comment

Uh oh!

danmoseley Feb 27, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jkotas commented Jan 3, 2020 •

edited

Loading