JIT: some GT_INDEX_ADDRs won't need throw helpers#124286
Merged
AndyAyersMS merged 3 commits intodotnet:mainfrom Feb 12, 2026
Merged
JIT: some GT_INDEX_ADDRs won't need throw helpers#124286AndyAyersMS merged 3 commits intodotnet:mainfrom
AndyAyersMS merged 3 commits intodotnet:mainfrom
Conversation
Saves a bit of code size for unoptimized methods. Also we should not see GT_ARR_ELEM post-morph.
github-actions
bot
added
the
area-CodeGen-coreclr
Member
Author
|
fyi @dotnet/jit-contrib |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines CoreCLR JIT throw-helper usage tracking to avoid conservatively marking range-check helpers as used when a GT_INDEX_ADDR doesn’t actually emit a bounds check (primarily benefiting MinOpts/unoptimized methods), and adds an invariant check that GT_ARR_ELEM should not appear post-morph.
Changes:
- Only mark
SCK_RNGCHK_FAILas used forGT_INDEX_ADDRwhenIsBoundsChecked()is true. - Add a debug assertion that
GT_ARR_ELEMshould not exist after morph (and stop treating it as a range-check-helper user here).
EgorBo
approved these changes
Feb 11, 2026
This was referenced Feb 12, 2026
Co-authored-by: SingleAccretion <[email protected]>
3 tasks
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
Saves a bit of code size for unoptimized methods. Also we should not see GT_ARR_ELEM post-morph. --------- Co-authored-by: SingleAccretion <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saves a bit of code size for unoptimized methods.
Also we should not see GT_ARR_ELEM post-morph.