Skip to content

Remove pinned Roslyn toolset version, use default from SDK#124297

Closed
Copilot wants to merge 4 commits intomainfrom
copilot/remove-roslyn-toolset-version
Closed

Remove pinned Roslyn toolset version, use default from SDK#124297
Copilot wants to merge 4 commits intomainfrom
copilot/remove-roslyn-toolset-version

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026 •
edited
Loading

  • Remove UsingToolMicrosoftNetCompilers property from eng/Versions.props to stop pulling in a pinned Roslyn compiler toolset
  • Remove MicrosoftNetCompilersToolsetPackageVersion from eng/Version.Details.props
  • Remove MicrosoftNetCompilersToolsetVersion alias from eng/Version.Details.props
  • Remove Microsoft.Net.Compilers.Toolset dependency from eng/Version.Details.xml
  • Keep DarcDependenciesChanged.Microsoft_Net_Compilers_Toolset check in eng/pipelines/common/xplat-setup.yml (per reviewer request)
  • Resolve merge conflicts with main (version bumps from 26069.103 to 26152.106)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove pinned Roslyn toolset version and use default SDK Remove pinned Roslyn toolset version, use default from SDK Feb 11, 2026
Copilot AI requested a review from agocke February 11, 2026 21:38
agocke
agocke reviewed Feb 11, 2026
View reviewed changes
Copilot AI requested a review from agocke February 11, 2026 21:44
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2026
@stephentoub stephentoub added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 11, 2026
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Feb 11, 2026

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

This was referenced Feb 12, 2026
Open
Open
Closed
Open
Closed
@agocke
Copy link
Member

agocke commented Mar 9, 2026

@copilot please resolve merge conflicts

Copy link
Contributor Author

Copilot AI commented Mar 9, 2026

@copilot please resolve merge conflicts

Merge conflicts resolved in 84d73e1. The conflicts were in eng/Version.Details.props and eng/Version.Details.xml due to version bumps on main (26069.103 → 26152.106). Resolved by taking main's updated versions while keeping the MicrosoftNetCompilersToolsetPackageVersion and Microsoft.Net.Compilers.Toolset dependency removed.

@akoeplinger
Copy link
Member

akoeplinger commented Mar 10, 2026

the Source-Build job failure looks related:

CSC : error CS9057: Analyzer assembly '/__w/1/s/artifacts/bin/ILLink.RoslynAnalyzer/Release/netstandard2.0/ILLink.RoslynAnalyzer.dll' cannot be used because it references version '5.6.0.0' of the compiler, which is newer than the currently running version '5.4.0.0'. [/__w/1/s/src/libraries/System.Private.CoreLib/ref/System.Private.CoreLib.csproj]

@agocke
Copy link
Member

agocke commented Mar 10, 2026

Yeah, I think I see what sourcebuild is trying to do here. I don't think it's ideal, but probably not worth trying to change it right now.

@agocke agocke closed this Mar 10, 2026
@akoeplinger akoeplinger deleted the copilot/remove-roslyn-toolset-version branch March 12, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoub stephentoub stephentoub approved these changes

@agocke agocke Awaiting requested review from agocke

Assignees

@agocke agocke

Copilot code review Copilot

Labels

area-Infrastructure

Projects

AppModel
Status: No status
Runtime Infra
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agocke @akoeplinger @stephentoub