Disable TestStackOverflowLargeFrameMainThread for x64 on Unix#124376
Disable TestStackOverflowLargeFrameMainThread for x64 on Unix#124376
Conversation
Co-authored-by: EgorBo <[email protected]>
Co-authored-by: EgorBo <[email protected]>
github-actions
bot
added
the
needs-area-label
|
@copilot revert the csproj change and disable the test for x64 arch inside |
…owLargeFrameMainThread Co-authored-by: EgorBo <[email protected]>
Co-authored-by: EgorBo <[email protected]>
Done. Reverted the csproj change and added x64 architecture check in |
|
PTAL @dotnet/jit-contrib I guess my PR #121300 to disable this test was unintentionally reverted recently when we migrated from issues.props to ActiveIssue. |
There was a problem hiding this comment.
Pull request overview
Disables the TestStackOverflowLargeFrameMainThread runtime test on Unix/macOS for additional architectures (notably x64) to avoid false negatives/incorrect SO classification in environments where stack probing behavior can prevent reliable stack overflow detection.
Changes:
- Add
Architecture.X64to the runtime skip condition forTestStackOverflowLargeFrameMainThreadon Unix/macOS. - Update the in-test comments describing which architectures are disabled and why.
|
At the point that we're disabling this test on linux x64, should we find some way to test the same thing more robustly? |
I'd say the actual issue needs to be fixed or studied if it's something important or not. I just wanted to make JIT PRs finally fully green |
…#124376) ## Description Disables the `TestStackOverflowLargeFrameMainThread` test for x64 architecture on Unix/MacOSX platforms by adding a runtime check within the test method itself. ## Changes - Added `Architecture.X64` to the architecture check in the `TestStackOverflowLargeFrameMainThread` method in `stackoverflowtester.cs` - Updated comments to clearly list all disabled architectures (ARM64, X64, RISCV64, and LoongArch64) - The comment now specifies that ARM64 and X64 are disabled due to dotnet#13519 The test now returns early for Arm64, X64, RiscV64, or LoongArch64 on Unix/MacOSX platforms, addressing the stack overflow detection issue where the current stack probing doesn't move the stack pointer and the runtime sometimes cannot recognize the underlying sigsegv as stack overflow when it probes too far from SP. The test remains enabled on Windows and for other architectures (x86, Arm) on all platforms. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: EgorBo <[email protected]>
|
Didn't seem like this actually disabled the test: https://github.com/dotnet/runtime/pull/124550/checks?check_run_id=64096192311 |
seems like it's a different [Fact] in that file. At this point it feels like this test has to be disabled or rewritten completely. it's currently disabled on most platforms already |
|
|
…#124376) ## Description Disables the `TestStackOverflowLargeFrameMainThread` test for x64 architecture on Unix/MacOSX platforms by adding a runtime check within the test method itself. ## Changes - Added `Architecture.X64` to the architecture check in the `TestStackOverflowLargeFrameMainThread` method in `stackoverflowtester.cs` - Updated comments to clearly list all disabled architectures (ARM64, X64, RISCV64, and LoongArch64) - The comment now specifies that ARM64 and X64 are disabled due to dotnet#13519 The test now returns early for Arm64, X64, RiscV64, or LoongArch64 on Unix/MacOSX platforms, addressing the stack overflow detection issue where the current stack probing doesn't move the stack pointer and the runtime sometimes cannot recognize the underlying sigsegv as stack overflow when it probes too far from SP. The test remains enabled on Windows and for other architectures (x86, Arm) on all platforms. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: EgorBo <[email protected]>
Description
Disables the
TestStackOverflowLargeFrameMainThreadtest for x64 architecture on Unix/MacOSX platforms by adding a runtime check within the test method itself.Changes
Architecture.X64to the architecture check in theTestStackOverflowLargeFrameMainThreadmethod instackoverflowtester.csThe test now returns early for Arm64, X64, RiscV64, or LoongArch64 on Unix/MacOSX platforms, addressing the stack overflow detection issue where the current stack probing doesn't move the stack pointer and the runtime sometimes cannot recognize the underlying sigsegv as stack overflow when it probes too far from SP.
The test remains enabled on Windows and for other architectures (x86, Arm) on all platforms.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.