Less optimistic checking for const vector to pattern checks#124599
Merged
jakobbotsch merged 9 commits intodotnet:mainfrom Feb 24, 2026
Merged
Less optimistic checking for const vector to pattern checks#124599jakobbotsch merged 9 commits intodotnet:mainfrom
jakobbotsch merged 9 commits intodotnet:mainfrom
Conversation
Fixes dotnet#124511 When checking a element of TBase size, ensure that no other bits other than the first bit are set
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a JIT bug in ARM64 SVE intrinsics where constant vector patterns were incorrectly validated, leading to wrong results. The issue was that EvaluateSimdMaskToPattern only checked the lowest bit of each mask element, allowing invalid masks with extra bits set to pass validation.
Changes:
- Enhanced mask validation to check all bits in each TBase-sized element, not just the lowest bit
- Renamed
finalOnetofirstZerofor clarity - Updated comments to better explain the mask format and validation logic
jakobbotsch
reviewed
Feb 19, 2026
src/tests/JIT/Regression/JitBlue/Runtime_124511/Runtime_124511.csproj
Outdated
Show resolved
Hide resolved
src/tests/JIT/Regression/JitBlue/Runtime_124511/Runtime_124511.cs
Outdated
Show resolved
Hide resolved
jakobbotsch
reviewed
Feb 19, 2026
src/tests/JIT/Regression/JitBlue/Runtime_124511/Runtime_124511.csproj
Outdated
Show resolved
Hide resolved
a74nh
changed the title
Member
|
Seems like one of the existing SVE regression tests is failing with this change. |
Contributor
Author
That's fixed now - just an issue with creating the mask for longs. |
jakobbotsch
approved these changes
Feb 24, 2026
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
…net#124599) When checking a element of TBase size, ensure that no other bits other than the first bit are set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124511
When checking a element of TBase size, ensure that no other bits other than the first bit are set