Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 by a74nh · Pull Request #124637 · dotnet/runtime

a74nh · 2026-02-20T12:50:19Z

Mostly a copy/paste of #115117

Mostly a copy/paste of dotnet#115117

dotnet-policy-service · 2026-02-20T12:51:35Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.

Changes:

Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/minipal/cpufeatures.h	Adds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.c	Detects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cpp	Sets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt	Registers new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.cs	Updates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.cs	Maps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.cs	Adds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.h	Introduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cpp	Adds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cpp	Extends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cpp	Enables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.h	Adds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.h	Bumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.h	Extends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.h	Adds CLRConfig switches to gate the new ARM64 ISAs.

src/native/minipal/cpufeatures.h

src/native/minipal/cpufeatures.c

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs

src/coreclr/inc/clrconfigvalues.h

src/coreclr/jit/jitconfigvalues.h

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs

a74nh · 2026-02-20T16:48:53Z

@dotnet/arm64-contrib
This is ready now

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

src/coreclr/jit/hwintrinsic.cpp

dhartglassMSFT · 2026-03-10T23:28:13Z

The changes to the jit all lgtm

a74nh · 2026-03-18T16:06:06Z

@jkotas - I think we need someone from your area to review this. Could you take a look please.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt


 ; The ISA definitions should also be mapped to `hwintrinsicIsaRangeArray` in hwintrinsic.cpp.
-; NEXT_AVAILABLE_R2R_BIT = 82
+; NEXT_AVAILABLE_R2R_BIT = 90


jkotas · 2026-03-18T16:18:58Z

src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

+instructionset     ,ARM64 ,Sha3                  ,           ,85 ,Sha3                  ,sha3
+instructionset     ,ARM64 ,Sm4                   ,           ,86 ,Sm4                   ,sm4
+instructionset     ,ARM64 ,SveAes                ,           ,87 ,SveAes                ,sve_aes
+instructionset     ,ARM64 ,SveSha3               ,           ,88 ,SveSha3               ,sve_sha3
+instructionset     ,ARM64 ,SveSm4                ,           ,89 ,SveSm4                ,sve_sm4


Does the copilot feedback needs addressing?

Does the copilot feedback needs addressing?

Yes, I'll take a look - they are new since I did the request :)

jkotas · 2026-03-18T16:19:17Z

@jkotas - I think we need someone from your area to review this. Could you take a look please.

@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?

I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.

a74nh · 2026-03-18T16:36:35Z

@jkotas - I think we need someone from your area to review this. Could you take a look please.

@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?

These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet

Approvals are:
#98696
#98692
#94426
#94425
#94423

I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.

Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.

If people agree, then I'm happy to drop these - and we'd remove them from #121787

Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4

6c8b642

Mostly a copy/paste of dotnet#115117

a74nh requested a review from MichalStrehovsky as a code owner February 20, 2026 12:50

Copilot AI review requested due to automatic review settings February 20, 2026 12:50

github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 20, 2026

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 20, 2026

a74nh marked this pull request as draft February 20, 2026 12:51

Copilot started reviewing on behalf of a74nh February 20, 2026 12:51 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

src/native/minipal/cpufeatures.h Show resolved Hide resolved

src/native/minipal/cpufeatures.c Show resolved Hide resolved

a74nh added 2 commits February 20, 2026 13:33

merge main

5ca73f6

Add to HardwareIntrinsicHelpers.cs

35d5c2e

Copilot AI review requested due to automatic review settings February 20, 2026 14:30

Copilot started reviewing on behalf of a74nh February 20, 2026 14:31 View session

Add PF_ARM_ define checks

a7e8db1

Copilot AI reviewed Feb 20, 2026

View reviewed changes

src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs Outdated Show resolved Hide resolved

src/coreclr/inc/clrconfigvalues.h Outdated Show resolved Hide resolved

src/coreclr/jit/jitconfigvalues.h Outdated Show resolved Hide resolved

Update src/coreclr/jit/jitconfigvalues.h

06c126e

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings February 20, 2026 14:38

a74nh and others added 2 commits February 20, 2026 14:38

Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs

04c6104

Co-authored-by: Copilot <[email protected]>

Update src/coreclr/inc/clrconfigvalues.h

96aa117

Co-authored-by: Copilot <[email protected]>

Copilot started reviewing on behalf of a74nh February 20, 2026 14:38 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs Show resolved Hide resolved

a74nh marked this pull request as ready for review February 20, 2026 16:48

a74nh added 2 commits February 23, 2026 12:49

Merge main

67bde34

Update jiteeversionguid

844b202

build-analysis bot mentioned this pull request Feb 23, 2026

[wasm/browser] Failed to connect to socket /run/dbus/system_bus_socket #120176

Open

This was referenced Feb 23, 2026

[wasm] Microsoft.Playwright.TargetClosedException : Target page, context or browser has been closed #121195

Closed

[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526

Open

a74nh added 2 commits February 26, 2026 11:44

merge main

161a07d

Update jiteeversionguid

eb6d66e

Copilot AI review requested due to automatic review settings February 26, 2026 11:45

Copilot started reviewing on behalf of a74nh February 26, 2026 11:46 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

dhartglassMSFT reviewed Mar 10, 2026

View reviewed changes

src/coreclr/jit/hwintrinsic.cpp Outdated Show resolved Hide resolved

dhartglassMSFT approved these changes Mar 10, 2026

View reviewed changes

Merge main

3191dcc

build-analysis bot mentioned this pull request Mar 11, 2026

XHarness DevToolsActivePort file doesn't exist #124438

Closed

merge main

02f674e

Copilot AI review requested due to automatic review settings March 18, 2026 16:01

Copilot started reviewing on behalf of a74nh March 18, 2026 16:02 View session

Add comment spaces

abf288d

a74nh requested a review from jkotas March 18, 2026 16:06

Copilot AI reviewed Mar 18, 2026

View reviewed changes

This was referenced Mar 18, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux #123216

Open

Conversation

a74nh commented Feb 20, 2026

Uh oh!

dotnet-policy-service bot commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

a74nh commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

dhartglassMSFT commented Mar 10, 2026

Uh oh!

a74nh commented Mar 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jkotas Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

a74nh Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas commented Mar 18, 2026

Uh oh!

a74nh commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants