Align final section to file alignment, not to virtual image size#124984
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Mar 11, 2026
Merged
Align final section to file alignment, not to virtual image size#124984jkoritzinsky merged 1 commit intodotnet:mainfrom
jkoritzinsky merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how PEObjectWriter determines the final on-disk size of emitted PE files so the file is padded only to file alignment, rather than being extended to the PE’s virtual image size (SizeOfImage), addressing reported self-contained app size regressions.
Changes:
- Stop padding the output stream length to
sizeOfImage. - Pad the final file length to
_peFileAlignmentinstead.
filipnavara
approved these changes
Feb 27, 2026
Member
filipnavara
left a comment
filipnavara
left a comment
There was a problem hiding this comment.
Looks good to me in principle.
This was referenced Feb 27, 2026
Member
|
Let’s add a unit test somewhere |
Member
|
Native aot has a test that checks to see its size and then fails if it’s too big |
davidwrighton
approved these changes
Mar 11, 2026
Member
Author
I'll add some tests in a future PR for R2R size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124980