Support InstructionSet_VectorT in HWIntrinsic importer#125226
Open
snickolls-arm wants to merge 5 commits intodotnet:mainfrom
Open
Support InstructionSet_VectorT in HWIntrinsic importer#125226snickolls-arm wants to merge 5 commits intodotnet:mainfrom
snickolls-arm wants to merge 5 commits intodotnet:mainfrom
Conversation
Add an empty intrinsic table for SVE-backed Vector<T> and implement some of the plumbing required to recognize these intrinsics on import.
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Mar 5, 2026
Open
10 tasks
Contributor
Author
|
@dotnet/arm64-contrib Please could I have a review on this patch? |
* Use compExactlyDependsOn * Improve Vector class name string matching * Remove unused sizes from assertion * Do not change Vector class name * Revert change to tryLookupSimdSize
tannergooding
approved these changes
Mar 17, 2026
| *pSimdSize = lookup(id).simdSize; | ||
| succeeded = true; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
nit, blank line not needed, then we dont need hwintrinsic.h in the changeset
| } | ||
| #elif defined(TARGET_ARM64) | ||
| if (compExactlyDependsOn(InstructionSet_VectorT128)) | ||
| #if defined(DEBUG) |
Contributor
There was a problem hiding this comment.
It's not clear to me why this is under ifdef DEBUG, can you explain?
| return InstructionSet_Vector128; | ||
| const char* suffix = className + 6; | ||
|
|
||
| if ((*suffix == '\0') || (strcmp(suffix, "`1") == 0)) |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((*suffix == '\0') || (strcmp(suffix, "`1") == 0)) | |
| if ((*suffix == '\0') || (strncmp(suffix, "`1", 2) == 0)) |
Contributor
There was a problem hiding this comment.
if you happen to be in this file again, obviously not a big deal either way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an empty intrinsic table for SVE-backed
Vector<T>and implement some of the plumbing required to recognize these intrinsics on import.