Port ComClassGenerator to string writing instead of constructing syntax nodes#125527
Conversation
|
Tagging subscribers to this area: @dotnet/interop-contrib |
jkoritzinsky
left a comment
There was a problem hiding this comment.
Looks pretty good! If you're taking a stab at this work, there's one more piece I'd like to figure out. Can we introduce a new type that doesn't store syntax nodes to handle the containing syntax (such as a type that, given syntax, computes a prefix, indent value to use for contents, and suffix)?
That way we could get to a point where we aren't passing syntax around between steps, as that's one of the main reasons we want to move to strings.
I would like to revisit pipeline models after we port all generators to strings. This way I can focus on the "back side" of the pipeline without diving into the data collection part of it. Yes, this generator is the simplest of them, but for others trying to tweak the front and the back side at the same time might be challenging. For the transition period syntax is still a good common denominator since it is both siutable for node construction and string writing due to convinience of |
|
I think that's reasonable. |
|
/ba-g ios failures unrelated |
The easiest part of #95882