[wasm][coreclr] Enable more libraries tests#125824
[wasm][coreclr] Enable more libraries tests#125824radekdoulik wants to merge 4 commits intodotnet:mainfrom
Conversation
radekdoulik
added
arch-wasm
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
Enables a broader set of library test suites to run under WASM CoreCLR by removing many browser/CoreCLR test exclusions and extending timeouts to accommodate longer execution.
Changes:
- Reduced the browser/CoreCLR test exclusion list to allow more test projects to execute.
- Increased Helix work item timeout for
TargetOS=browser+RuntimeFlavor=CoreCLR. - Increased the XHarness per-suite timeout for WASM tests when
RuntimeFlavor=CoreCLR.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/tests.proj | Removes many browser/CoreCLR exclusions, reclassifies remaining exclusions (failures vs long-running). |
| src/libraries/sendtohelixhelp.proj | Raises Helix _workItemTimeout for browser/CoreCLR to 2 hours. |
| eng/testing/tests.wasm.targets | Raises WasmXHarnessTestsTimeout for CoreCLR to 2 hours. |
| <_workItemTimeout Condition="'$(_workItemTimeout)' == '' and '$(TargetOS)' == 'android'">00:30:00</_workItemTimeout> | ||
| <_workItemTimeout Condition="'$(_workItemTimeout)' == '' and '$(TargetOS)' == 'browser' and '$(RuntimeFlavor)' == 'CoreCLR'">01:30:00</_workItemTimeout> | ||
| <_workItemTimeout Condition="'$(_workItemTimeout)' == '' and '$(TargetOS)' == 'browser'">00:30:00</_workItemTimeout> |
There was a problem hiding this comment.
This change updates the Helix work item timeout for browser+CoreCLR to 01:30:00, and eng/testing/tests.wasm.targets separately sets the xharness --timeout default to the same value. Having the same magic duration defined in two places is easy to let drift (e.g., someone updates one but not the other). Consider factoring this into a single shared property (or deriving one timeout from the other) so CoreCLR wasm timeout policy is defined once.
No description provided.