NativeCallableAttribute to UnmanagedCallersOnlyAttribute#35592
Merged
AaronRobinsonMSFT merged 2 commits intodotnet:masterfrom Apr 29, 2020
Merged
NativeCallableAttribute to UnmanagedCallersOnlyAttribute#35592AaronRobinsonMSFT merged 2 commits intodotnet:masterfrom
AaronRobinsonMSFT merged 2 commits intodotnet:masterfrom
Conversation
Replace NativeCallableAttribute usage with UnmanagedCallersOnlyAttribute. Update tests. Update coreclr implementation to reflect new name.
Member
Author
|
@jkotas Should this be marked "breaking change" since it breaks code with previous previews? |
Member
No. Breaking changes between regular previews are not tracked as breaking changes (exception are late previews with go-live support). |
jkotas
reviewed
Apr 29, 2020
...s/System.Private.CoreLib/src/System/Runtime/InteropServices/UnmanagedCallersOnlyAttribute.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Apr 29, 2020
…pServices/UnmanagedCallersOnlyAttribute.cs Co-Authored-By: Jan Kotas <[email protected]>
stephentoub
approved these changes
Apr 29, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
NativeCallableAttributeusage withUnmanagedCallersOnlyAttribute.Update tests.
Update coreclr implementation to reflect new name.
Fixes: #35433
/cc @jkotas @jkoritzinsky @elinor-fung