WASM: Fix System.Formats.Asn1 tests#39104
Merged
akoeplinger merged 2 commits intodotnet:masterfrom Jul 11, 2020
Merged
Conversation
Disable tests that rely on crypto APIs which don't work on WebAssembly right now which allows the test suite to pass: `Tests run: 3406, Errors: 0, Failures: 0, Skipped: 0. Time: 5.296689s`
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
99 tasks
bartonjs
approved these changes
Jul 10, 2020
safern
reviewed
Jul 10, 2020
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.FileSystem\tests\System.IO.FileSystem.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.MemoryMappedFiles\tests\System.IO.MemoryMappedFiles.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.Packaging\tests\System.IO.Packaging.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.Pipes\tests\System.IO.Pipes.Tests.csproj" /> |
Member
There was a problem hiding this comment.
Didn't you already do this in another PR?
Member
Author
There was a problem hiding this comment.
No I forgot to do it there :)
Member
There was a problem hiding this comment.
Oh, haha and I missed it as well in ALL those PRs, 🤦
safern
approved these changes
Jul 10, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable tests that rely on crypto APIs which don't work on WebAssembly right now which allows the test suite to pass:
Tests run: 3406, Errors: 0, Failures: 0, Skipped: 0. Time: 5.296689sAlso enables a few test suites in tests.proj that I forgot to enable in previous PRs.