Annotate TypeConverterAttribute so that the ILLinker preserves the ctor on the converter#39144
Merged
layomia merged 4 commits intodotnet:masterfrom Jul 24, 2020
Merged
Annotate TypeConverterAttribute so that the ILLinker preserves the ctor on the converter#39144layomia merged 4 commits intodotnet:masterfrom
layomia merged 4 commits intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: @safern |
eerhardt
reviewed
Jul 13, 2020
src/libraries/System.ObjectModel/src/System/ComponentModel/TypeConverterAttribute.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 23, 2020
src/libraries/System.ObjectModel/tests/TrimmingTests/TypeConverterAttributeCtorTest.cs
Show resolved
Hide resolved
eerhardt
reviewed
Jul 23, 2020
src/libraries/System.ObjectModel/tests/TrimmingTests/TypeConverterAttributeCtorTest.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Jul 23, 2020
src/libraries/System.ObjectModel/tests/TrimmingTests/TypeConverterAttributeCtorTest.cs
Outdated
Show resolved
Hide resolved
joperezr
approved these changes
Jul 23, 2020
Member
joperezr
left a comment
There was a problem hiding this comment.
Left a small question but otherwise this looks good!
Contributor
Author
|
CI run appears to be complete https://dev.azure.com/dnceng/public/_build/results?buildId=743476&view=logs&j=a9d0dd01-e81d-52b7-e673-948d9174db20. |
eerhardt
reviewed
Jul 27, 2020
Member
eerhardt
left a comment
There was a problem hiding this comment.
We should have also removed this workaround which was linked to this bug:
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…or on the converter (dotnet#39144) * Annotate TypeConverterAttribute so that the ILLinker preserves the ctor on the converter * Address review feedback & add attributes to ref * Use custom enum converter type * Split tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39125