Skip to content

Implement concept of unstable ABI into crossgen2#40820

Merged
janvorli merged 2 commits intodotnet:masterfrom
davidwrighton:fix_vector_not_spc_aware
Aug 17, 2020
Merged

Implement concept of unstable ABI into crossgen2#40820
janvorli merged 2 commits intodotnet:masterfrom
davidwrighton:fix_vector_not_spc_aware

Conversation

@davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Aug 14, 2020

  • Use for the Vector types based on current defined stability rules
  • Will prevent compilation of methods with not yet stable abis, or calls to methods with said unstable apis

Fixes #13522

@davidwrighton
Implement concept of unstable ABI into crossgen2
274d005 
- Use for the Vector types based on current defined stability rules
- Will prevent compilation of methods with not yet stable abis, or calls to methods with said unstable apis
@davidwrighton
Bugs
0f08862
@davidwrighton davidwrighton requested a review from janvorli August 14, 2020 04:39
@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Aug 14, 2020

We're already doing something similar for Vector<T>: we basically just say that the layout in Indeterminate and there's code checking for that that aborts crossgening the method whenever a piece of layout info is needed and it ends up Indeterminate.

Do we need to introduce a new general purpose mechanism here? Could we just have a FieldLayoutAlgorithm that returns Indeterminate layout for these same as for Vector<T> but only do it if the version bubble doesn't include CoreLib?

Cc @dotnet/crossgen-contrib

janvorli
janvorli approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok, but I wonder about the same thing that @MichalStrehovsky said. It seems it would make the change more local.

@davidwrighton
Copy link
Member Author

davidwrighton commented Aug 14, 2020

Unfortunately, making the types have indeterminate size also prevents usage of the Vector intrinsics. This approach allows the intrinsics to continue to work and use the Vector128/256 types while simultaneously not permitting these apis to cross an ABI boundary.

@janvorli
Copy link
Member

janvorli commented Aug 14, 2020

Makes sense.

@janvorli janvorli merged commit b41f1c5 into dotnet:master Aug 17, 2020
@alpencolt alpencolt mentioned this pull request Nov 19, 2020
Open
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@davidwrighton davidwrighton deleted the fix_vector_not_spc_aware branch April 20, 2021 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorli janvorli janvorli approved these changes

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees

No one assigned

Labels

area-crossgen2-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[crossgen2] Making sure Vector64/128/256 are not generated unless CoreLib is part of the version bubble

4 participants

@davidwrighton @MichalStrehovsky @janvorli @Dotnet-GitSync-Bot