Make Process.WaitForExitAsync wait for redirected output reads#42585
Merged
eiriktsarpalis merged 6 commits intodotnet:masterfrom Sep 28, 2020
Merged
Conversation
Addresses an issue where Process.WaitForExitAsync doesn't wait for background redirected output reads, a behaviour which diverges from the sync method equivalent. Fixes dotnet#42556.
|
Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley |
eiriktsarpalis
commented
Sep 22, 2020
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 22, 2020
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/AsyncStreamReader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 22, 2020
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
commented
Sep 23, 2020
src/libraries/Common/src/System/Threading/Tasks/TaskTimeoutExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/Common/src/System/Threading/Tasks/TaskTimeoutExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/Common/src/System/Threading/Tasks/TaskTimeoutExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/Common/src/System/Threading/Tasks/TaskTimeoutExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/Common/src/System/Threading/Tasks/TaskTimeoutExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/Common/src/System/Threading/Tasks/TaskTimeoutExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/AsyncStreamReader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 23, 2020
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs
Show resolved
Hide resolved
stephentoub
reviewed
Sep 28, 2020
src/libraries/Common/src/System/Threading/Tasks/TaskTimeoutExtensions.cs
Outdated
Show resolved
Hide resolved
…ensions.cs Co-authored-by: Stephen Toub <[email protected]>
stephentoub
approved these changes
Sep 28, 2020
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
LGTM once the cited boxing issue is addressed. Thanks.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue where Process.WaitForExitAsync doesn't wait for background redirected output reads, a behaviour which diverges from the sync method equivalent. Fixes #42556.
cc @adamsitnik @stephentoub