Fix and reenable TestUserCredentialsPropertiesOnWindows by adamsitnik · Pull Request #46083 · dotnet/runtime

adamsitnik · 2020-12-15T18:40:55Z

Removal of the user via Interop.NetUserDel was never working because it was missing CharSet = CharSet.Unicode. I've fixed that and changed the test to:

use more unique name than "test"
always try to remove the test account first
fail (don't swallow the exception) if the creation of the account failed
fail (don't ignore error code NERR_UserNotFound) if the removal of the account failed

The user might have been missing rights to read and execute dotnet.exe (for example when build.cmd was executed from Admin PSW) and in that case the test was throwing Access denied from Process.Start. I've changed the test to always add the permission to read and execute before running the .exe

Now it works as expected:

Fixes #18978

…erly

…denied exception)

ghost · 2020-12-15T18:40:58Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Removal of the user via Interop.NetUserDel was never working because it was missing CharSet = CharSet.Unicode. I've fixed that and changed the test to:
* use more unique name than "test"
* always try to remove the test account first
* fail (don't swallow the exception) if the creation of the account failed
* fail (don't ignore error code NERR_UserNotFound) if the removal of the account failed

The user might have been missing rights to read and execute dotnet.exe (for example when build.cmd was executed from Admin PSW) and in that case the test was throwing Access denied from Process.Start. I've changed the test to always add the permission to read and execute before running the .exe

Now it works as expected:

Author:	adamsitnik
Assignees:	-
Labels:	`area-System.Diagnostics.Process`
Milestone:	6.0.0

eiriktsarpalis

If CI is happy I'm happy.

adamsitnik · 2020-12-16T11:28:13Z

/azp run runtime-libraries outerloop

azure-pipelines · 2020-12-16T11:28:18Z

No pipelines are associated with this pull request.

adamsitnik · 2020-12-16T11:37:06Z

/azp list

azure-pipelines · 2020-12-16T11:37:11Z

CI/CD Pipelines for this repository: coreclr-gc-longrunning coreclr-gc-simulator runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr r2r-extra runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-live-build runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly sync-runtime-to-mono runtime-coreclr crossgen2-composite runtime-jit-experimental dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr clrinterpreter runtime-coreclr crossgen2-composite gcstress runtime-libraries-mono outerloop runtime-staging

adamsitnik · 2020-12-16T11:38:00Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2020-12-16T11:39:08Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-16T13:35:25Z

We stopped hearing from agent NetCorePublic-Pool 1. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error

So here we go again

/azp run runtime-libraries-coreclr outerloop-windows

adamsitnik · 2020-12-16T13:38:05Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2020-12-16T13:38:20Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-16T15:12:56Z

The CI has failed with a very interesting error:

    System.Diagnostics.Tests.ProcessStartInfoTests.TestUserCredentialsPropertiesOnWindows [FAIL]
      System.DllNotFoundException : Unable to load DLL 'netapi32.dll' or one of its dependencies: The specified module could not be found. (0x8007007E)
      Stack Trace:
           at System.Diagnostics.Tests.Interop.NetUserDel(String servername, String username)
        /_/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs(360,0): at System.Diagnostics.Tests.ProcessStartInfoTests.TestUserCredentialsPropertiesOnWindows()

edit: because 'netapi32.dll' is not available on nano

# Conflicts: # src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs

adamsitnik · 2020-12-16T15:57:01Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2020-12-16T15:57:15Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-16T17:45:55Z

If CI is happy I'm happy

The CI is happy and so am I ;)

adamsitnik added 5 commits December 15, 2020 17:34

add missing CharSet = CharSet.Unicode so the NetUserDel can work prop…

2fa2c61

…erly

make the user name more unique, ensure that it's always removed properly

c11cc9b

ensure the new user can access the .exe (otherwise you get Access is …

1f55d49

…denied exception)

remove active issue attribute

4820604

nits

1fac03c

adamsitnik added the area-System.Diagnostics.Process label Dec 15, 2020

adamsitnik added this to the 6.0.0 milestone Dec 15, 2020

adamsitnik requested a review from eiriktsarpalis December 15, 2020 18:40

eiriktsarpalis approved these changes Dec 16, 2020

View reviewed changes

adamsitnik added the disabled-test The test is disabled in source code against the issue label Dec 16, 2020

adamsitnik added 2 commits December 16, 2020 16:52

don't run this test on Nano, as it has no "netapi32.dll"

c52e74f

Merge remote-tracking branch 'upstream/master' into 18978

5e77c96

# Conflicts: # src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs

adamsitnik merged commit 93e767b into dotnet:master Dec 16, 2020

adamsitnik deleted the 18978 branch December 16, 2020 17:46

jeffhandley mentioned this pull request Jan 13, 2021

Fix System.Diagnostics.Process tests #46941

Closed

6 tasks

adamsitnik mentioned this pull request Jan 15, 2021

make TestUserCredentialsPropertiesOnWindows stable on Windows Server Core #47031

Merged

ghost locked as resolved and limited conversation to collaborators Jan 15, 2021

Conversation

adamsitnik commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 15, 2020

Uh oh!

eiriktsarpalis left a comment

Choose a reason for hiding this comment

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

azure-pipelines bot commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

azure-pipelines bot commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

azure-pipelines bot commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

azure-pipelines bot commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

azure-pipelines bot commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adamsitnik commented Dec 15, 2020 •

edited

Loading

adamsitnik commented Dec 16, 2020 •

edited

Loading