Superpmi on Microbenchmarks#47900
Merged
kunalspathak merged 36 commits intodotnet:masterfrom Feb 13, 2021
Merged
Conversation
09ce331 to
eec8463
Compare
b5b0362 to
afdfbd4
Compare
Also update the GUID so we don't overwrite the existing collections.
- Disable mcs -strip for now - Pass the JitName variable
This reverts commit afdfbd4b03a684d780ef06f644dba0dcf0621438.
9cc583d to
8d8c7b5
Compare
Contributor
Author
Contributor
Author
|
@dotnet/jit-contrib |
20 tasks
BruceForstall
approved these changes
Feb 12, 2021
| from os.path import isfile | ||
| from shutil import copyfile | ||
| from coreclr_arguments import * | ||
| from superpmi import ChangeDir, TempDir |
Contributor
There was a problem hiding this comment.
I'm not fond of anyone depending on superpmi.py; it makes it more fragile to change without potentially breaking (unknown) dependents.
Contributor
Author
There was a problem hiding this comment.
I agree. There are few methods in super_setup.py as well that I will extract in a superpmi_utils.py file in a future PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perform automated superpmi collection on Microbenchmarks during their execution.
Currently, I have disable the collection for Linux arm/arm64 because it needs special handling to perform "dotnet MicroBenchmarks.dll" inside a
$TMPfolder because during execution of benchmarks, we also perform build of boiler plate code which is not allowed in docker since the directory is readonly.Contributes to #43227