Fix json converters not disposing enumerators#48322
Merged
layomia merged 2 commits intodotnet:masterfrom Feb 16, 2021
Merged
Conversation
-Fix converters not disposing enumerators (issue dotnet#46349) -Add tests
NewellClark
requested review from
eiriktsarpalis,
jozkee,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsFix issue #46349 in
|
…spose-enumerators
Contributor
Author
|
Just hit issue #35752. Rerunning. |
steveharter
approved these changes
Feb 16, 2021
Contributor
steveharter
left a comment
steveharter
left a comment
There was a problem hiding this comment.
LGTM; verified all collection types are modified except the non-generic IEnumerable-based ones which don't implement IDisposable.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #46349 in
System.Text.Json