Skip to content

Fix to build mono on Windows with ninja by default as well#50793

Merged
akoeplinger merged 1 commit intodotnet:mainfrom
akoeplinger:fix-mono-windows-ninja
Apr 6, 2021
Merged

Fix to build mono on Windows with ninja by default as well#50793
akoeplinger merged 1 commit intodotnet:mainfrom
akoeplinger:fix-mono-windows-ninja

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Apr 6, 2021 •
edited
Loading

This got broken by 8c2158f since we no longer passed /p:Ninja=true down to mono.proj from build.cmd/ps1

Fixes #50753

@akoeplinger
Fix to build mono on Windows with ninja by default as well
bfebf5d 
This got broken by dotnet@8c2158f since we no longer passed /p:Ninja=true down to mono.proj
@akoeplinger akoeplinger requested a review from marek-safar as a code owner April 6, 2021 18:58
@ghost
Copy link

ghost commented Apr 6, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This got broken by 8c2158f since we no longer passed /p:Ninja=true down to mono.proj

Fixes #50753

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: -

@akoeplinger akoeplinger requested a review from jkoritzinsky April 6, 2021 18:58
@akoeplinger
Copy link
Member Author

akoeplinger commented Apr 6, 2021

Looks like this was missed in the initial PR because it didn't touch any files in src/mono so CI didn't trigger mono legs.

@safern should we add eng/* as triggers to eng/pipelines/common/evaluate-default-paths.yml?

@safern
Copy link
Member

safern commented Apr 6, 2021

Hmmm that should already be included:

https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/evaluate-default-paths.yml#L28-L45

@safern
Copy link
Member

safern commented Apr 6, 2021 •
edited
Loading

I do see mono build running on that PR build:

https://dev.azure.com/dnceng/public/_build/results?buildId=1054503&view=logs&j=e4304a73-856f-5230-44ef-10471e0044a5

Also this is the output for evaluate paths for the mono subset:

******* Probing mono exclude paths *******
eng/Version.Details.xml
*.md
LICENSE.TXT
PATENTS.TXT
THIRD-PARTY-NOTICES.TXT
docs/*
src/installer/*
src/coreclr/*
src/libraries/*
src/tests/*
eng/pipelines/installer/*
eng/pipelines/coreclr/*
eng/pipelines/libraries/*

+ git diff -M -C -b --ignore-cr-at-eol --ignore-space-at-eol --exit-code --quiet 'HEAD^1' -- ':!eng/Version.Details.xml' ':!*.md' ':!LICENSE.TXT' ':!PATENTS.TXT' ':!THIRD-PARTY-NOTICES.TXT' ':!docs/*' ':!src/installer/*' ':!src/coreclr/*' ':!src/libraries/*' ':!src/tests/*' ':!eng/pipelines/installer/*' ':!eng/pipelines/coreclr/*' ':!eng/pipelines/libraries/*'

----- Matching files for mono -----
+ git diff -M -C -b --ignore-cr-at-eol --ignore-space-at-eol --name-only 'HEAD^1' -- ':!eng/Version.Details.xml' ':!*.md' ':!LICENSE.TXT' ':!PATENTS.TXT' ':!THIRD-PARTY-NOTICES.TXT' ':!docs/*' ':!src/installer/*' ':!src/coreclr/*' ':!src/libraries/*' ':!src/tests/*' ':!eng/pipelines/installer/*' ':!eng/pipelines/coreclr/*' ':!eng/pipelines/libraries/*'
eng/build.ps1
eng/native/configurecompiler.cmake
eng/native/functions.cmake
eng/pipelines/global-build.yml
src/native/corehost/CMakeLists.txt
src/native/corehost/build.cmd

Setting pipeline variable containsChange=true

And here is the build for Browser on Windows that ran on that PR:
https://dev.azure.com/dnceng/public/_build/results?buildId=1054506&view=logs&jobId=4ffd1c85-149a-52c0-00e1-0d9c3af850ba&j=4ffd1c85-149a-52c0-00e1-0d9c3af850ba&t=9fe9d5a4-3635-5eda-7e39-9e2c5e3efbab

@akoeplinger
Copy link
Member Author

akoeplinger commented Apr 6, 2021

@safern hmm you're right, it did run in the PR. I was confused because GitHub doesn't show it in the PR result summary at the end of the PR (only lists 100 statuses there) but does show it on the Checks tab:

image

vs.

image

This PR should still fix the issue though.

@akoeplinger
Copy link
Member Author

akoeplinger commented Apr 6, 2021

Mono crossaot Product Build windows x64 release passed, the other failures are infrastructure issues.

@akoeplinger akoeplinger merged commit b3d4eb2 into dotnet:main Apr 6, 2021
@akoeplinger akoeplinger deleted the fix-mono-windows-ninja branch April 6, 2021 22:58
@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@safern safern safern approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

+1 more reviewer

@directhex directhex directhex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-mono

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Mono Windows Cross build failing

5 participants

@akoeplinger @safern @directhex @jkoritzinsky @karelz