Merged
Conversation
|
Tagging subscribers to this area: @tommcdon Issue Details
|
Contributor
Author
|
Feel free to abandon/close this if you have your own/better/tested patch. |
Member
|
This is pretty much the same patch I had already. I am just testing this one now. Decided against 512 bit bypass as all other places of the decoder lack support. |
hoyosjs
approved these changes
Jun 11, 2021
hoyosjs
added a commit
to hoyosjs/runtime
that referenced
this pull request
Jun 11, 2021
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
This reverts commit b2fe667.
jeffschwMSFT
pushed a commit
that referenced
this pull request
Jun 25, 2021
This reverts commit b2fe667. Co-authored-by: Juan Hoyos <[email protected]>
tommcdon
pushed a commit
that referenced
this pull request
Jun 26, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have not tested this, but the code is clearly wrong. We need a 32-byte buffer to copy the literals for a ymm (256-bit) register.
@hoyosjs Can you test and backport this to .NET 5. I think the full change is safer for servicing, but you could also reduce to a one-line patch.
Fixes #54025