Delete code under FEATURE_NATIVE_IMAGE_GENERATION#57669
Merged
elinor-fung merged 2 commits intodotnet:mainfrom Aug 18, 2021
Merged
Delete code under FEATURE_NATIVE_IMAGE_GENERATION#57669elinor-fung merged 2 commits intodotnet:mainfrom
FEATURE_NATIVE_IMAGE_GENERATION#57669elinor-fung merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
mangod9
reviewed
Aug 18, 2021
| @@ -677,7 +621,6 @@ struct ModuleCtorInfo | |||
|
|
|||
| #ifdef FEATURE_PREJIT | |||
Member
Author
There was a problem hiding this comment.
I'm planning on doing a pass of removing everything under FEATURE_PREJIT in a separate change. (This change happens to do some of it because those two defines were rather intertwined in some places)
trylek
approved these changes
Aug 18, 2021
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Nice, thank you, I haven't seen this many lines deleted in such a short time for quite a while!
AaronRobinsonMSFT
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a coarse removal of code under
FEATURE_NATIVE_IMAGE_GENERATION. There's a bunch of actual cleanup we can do (for example, handling functions that now always return true/false/null) - I wanted this PR to avoid actual logic changes/cleanup and just be deleting dead code.It also ended up removing parts of the dead code under
FEATURE_PREJIT(larger removal to come), since some functions had implementations under one define and declarations under the other.Found this tool to help with removing ifdef-ed out code: https://dotat.at/prog/unifdef/
Fixes #57658
Contributes to #54129 and #53007
cc: @dotnet/crossgen-contrib @AaronRobinsonMSFT @elinor-fung @jkotas @agocke