Remove FEATURE_READYTORUN_COMPILER define from non-JIT code.#57672
Merged
3 commits merged intodotnet:mainfrom Aug 18, 2021
Merged
Remove FEATURE_READYTORUN_COMPILER define from non-JIT code.#576723 commits merged intodotnet:mainfrom
FEATURE_READYTORUN_COMPILER define from non-JIT code.#576723 commits merged intodotnet:mainfrom
Conversation
ghost
added
the
AaronRobinsonMSFT
changed the title
FEATURE_READYTORUN_COMPILER define from non-JIT code.
Member
|
There seems to be a fair bit of overlap with #57669. Thoughts on waiting until the larger one is in? |
Member
Author
|
I'm fine with waiting |
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove all code that required
IsReadyToRunCompilation()to betrue, since after removing theFEATURE_READYTORUN_COMIPLERdefine from the VM it is always false.Fixes #57659
Contributes to #54129 and #53007
cc: @dotnet/crossgen-contrib @AaronRobinsonMSFT @elinor-fung @jkotas @agocke