Remove usages of FEATURE_NGEN_RELOCS_OPTIMIZATIONS#57673
Merged
1 commit merged intodotnet:mainfrom Aug 18, 2021
Merged
Conversation
ghost
added
the
jkotas
reviewed
Aug 18, 2021
| && pSharedMD->IsVtableSlot(); | ||
|
|
||
| #ifndef FEATURE_NGEN_RELOCS_OPTIMIZATIONS | ||
| _ASSERTE(!isRelative); |
Member
There was a problem hiding this comment.
I assume that cleaning up of these conditions and types like RelativePointer or FixupPointer is left for future change.
Member
Author
There was a problem hiding this comment.
Yes, that is left for a future change.
jkotas
approved these changes
Aug 18, 2021
trylek
approved these changes
Aug 18, 2021
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
LGTM, looks like CG1 code in the CoreCLR subrepo won't see the end of August :D.
AaronRobinsonMSFT
approved these changes
Aug 18, 2021
elinor-fung
approved these changes
Aug 18, 2021
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57661
Contributes to #54129 and #53007
cc: @dotnet/crossgen-contrib @AaronRobinsonMSFT @elinor-fung @jkotas @agocke