Add linux-musl entry for FALLBACK_HOST_RID#65339
Conversation
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsFixes #65152
|
| OUTPUT_STRIP_TRAILING_WHITESPACE) | ||
|
|
||
| execute_process( | ||
| COMMAND bash -c "if strings \"${CMAKE_SYSROOT}/usr/bin/ldd\" 2>&1 | grep -q musl; then echo musl; fi" |
There was a problem hiding this comment.
cc @janvorli, @vitek-karas, I have used same detection mechanism as we have used in:
runtime/eng/native/init-distro-rid.sh
Lines 163 to 164 in 8e4bef2
as fragile as it seems, it just works.
|
Actually - spoke too soon. The version-less windows RID breaks some tests. I looked at one of them ( That said - maybe we should split these changes into two different PRs. |
janvorli
left a comment
There was a problem hiding this comment.
The change looks good, but I leave the fallback rid resolution decision to the host folks.
|
@am11 could you please remove the |
6fa61b4 to
3858aa7
Compare
|
@vitek-karas, I have removed the win commit for later time. BTW, looks like we need to unescape linefeeds in failing test logs: |
|
I checked offline with others that all the failures in the CI run are unrelated (and mostly known problems which are being worked on). |
|
Re escaping newlines - I haven't looked into that yet, but I suspect it's some weird interaction with the testing framework. |
|
Thanks a lot @am11! |

Fixes #65152