Expose APIs for getting the exponent and significand for IFloatingPoint types#68094
Merged
tannergooding merged 5 commits intodotnet:mainfrom Apr 18, 2022
Merged
Expose APIs for getting the exponent and significand for IFloatingPoint types#68094tannergooding merged 5 commits intodotnet:mainfrom
tannergooding merged 5 commits intodotnet:mainfrom
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis is a continuation of #67939, but for the floating-point types
|
This was referenced Apr 18, 2022
Closed
dakersnar
approved these changes
Apr 18, 2022
Contributor
dakersnar
left a comment
dakersnar
left a comment
There was a problem hiding this comment.
Looks good! Minor nitpicks on some of the documentation.
Co-authored-by: Drew Kersnar <[email protected]>
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
…nt types (dotnet#68094) * Updating Half/Single/Double to consistently track the internal bitwise manipulation constants * Expse APIs for getting the exponent and significand for IFloatingPoint types * Expose tests for getting the exponent and significand for IFloatingPoint types * Apply suggestions from code review Co-authored-by: Drew Kersnar <[email protected]> * Assert that decimal.Exponent is between 95 and 67, inclusive Co-authored-by: Drew Kersnar <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #67939, but for the floating-point types