JIT ARM32: Fix wrong emitAttr passed for loads/stores in PUTARG_STK#68540
Merged
jakobbotsch merged 2 commits intodotnet:mainfrom Apr 27, 2022
Merged
JIT ARM32: Fix wrong emitAttr passed for loads/stores in PUTARG_STK#68540jakobbotsch merged 2 commits intodotnet:mainfrom
jakobbotsch merged 2 commits intodotnet:mainfrom
Conversation
On arm architectures the small load/store instructions all work larger registers and for loads the instruction automatically normalizes the result. Due to this we always expect to pass the normalized size for loads/stores when generating these instructions, but in this particular place we did not do so, resulting in asserts on arm32. On arm64 the function ignores the size so nothing happens. Fix dotnet#60827
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsOn arm architectures the small load/store instructions all work larger On arm64 the function ignores the size so nothing happens. I assume this is the right fix based on cc @dotnet/jit-contrib PTAL @BruceForstall
|
This was referenced Apr 26, 2022
Closed
BruceForstall
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On arm architectures the small load/store instructions all work larger
registers and for loads the instruction automatically normalizes the
result. Due to this we always expect to pass the normalized size for
loads/stores when generating these instructions, but in this particular
place we did not do so, resulting in asserts on arm32.
On arm64 the function ignores the size so nothing happens.
I assume this is the right fix based on
genCodeForIndirandgenCodeForStoreIndthat both useemitActualTypeSizewhen emitting these same instructions.cc @dotnet/jit-contrib PTAL @BruceForstall
Fix #60827