Implement ICorProfilerInfo13 to support object handle creation/destruction/access#71257
Implement ICorProfilerInfo13 to support object handle creation/destruction/access#71257davmason merged 15 commits intodotnet:mainfrom
Conversation
ghost
added
community-contribution
|
Tagging subscribers to this area: @tommcdon Issue DetailsIn the context of #55888, 3 methods are added to ICorProfilerInfo to manage strong, weak and pinned handles. The first usage will be to wrap the reference provided by AllocationTick_V4 by a weak reference handle and use them to figure out if the object is still alive after a certain amount of time. This should help building automatic memory leak detection system.
|
chrisnas
force-pushed
the
profiler-can-create-handles
branch
from
75571c0 to
2a38e20
Compare
|
@chrisnas if closing it was by accident, you should be able to reopen it. I can't for some reason |
|
git error... |
davmason
left a comment
davmason
left a comment
There was a problem hiding this comment.
Just a few small changes, otherwise looks good to me!
| break; | ||
|
|
||
| default: | ||
| handle = NULL; |
There was a problem hiding this comment.
We should return E_INVALIDARG in this case
There was a problem hiding this comment.
✅ Good point. I'm also setting *pHandle to NULL
ghost
added
needs-author-action
|
@chrisnas I think this is ready to merge, when are you planning on doing the docs on docs.microsoft.com? I would really prefer to wait for a docs PR before merging, otherwise docs tend to never get done. |
@davmason : is there anything else to do beyond dotnet/docs#30131? |
Nope, just missed that PR. Thanks, I'll merge this now |
ghost
locked as resolved and limited conversation to collaborators
3 participants
In the context of #49424, 3 methods are added to ICorProfilerInfo to manage strong, weak and pinned handles.
The first usage will be to wrap the reference provided by AllocationTick_V4 by a weak reference handle and use them to figure out if the object is still alive after a certain amount of time. This should help building automatic memory leak detection system.
Note: the corresponding documentation is made available via dotnet/docs#30131