[Mono] Fix all remaining C4018 warnings and enable the check during build#71269
[Mono] Fix all remaining C4018 warnings and enable the check during build#71269fanyang-mono merged 22 commits intodotnet:mainfrom
Conversation
fanyang-mono
requested review from
BrzVlad,
SamMonoRT,
lambdageek,
lateralusX,
marek-safar,
naricc,
thaystg and
vargaz
as code owners
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
couple of nits but mostly LGTM.
I do think that business with the membase_offset instructions needs to be addressed in another way. the offset should be signed.
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
lateralusX
left a comment
lateralusX
left a comment
There was a problem hiding this comment.
Looked through all except:
aot-compiler.c and mini-llvm.c.
There are several occasions where we switched from int to uint but kept use of %d in formatting masks using the variable. I have not flagged them since they will still be ok according to size, but formatting string will still interpret the value as a signed int, I guess that is still ok, so I have not made any additional comments on that pattern.
Thanks for working through and fix the remaining C4018, great work!
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
ghost
locked as resolved and limited conversation to collaborators
4 participants
Fix remaining C4018 warnings on Mono runtime x86/x64 Windows build, aligning with SDL requirements (#66154).