[wasm][debugger] Adding support to receive evaluationOptions from dap.#71464
[wasm][debugger] Adding support to receive evaluationOptions from dap.#71464thaystg merged 8 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @thaystg Issue DetailsTo support receiving EvaluationOptions from dap. Then we will be able to auto evaluate properties or not based on what is defined on VS settings. Depends on:
|
src/mono/wasm/debugger/BrowserDebugProxy/MemberObjectsExplorer.cs
Outdated
Show resolved
Hide resolved
|
Can we add a test where it sends the setting, and we check if properties are being auto expanded or not? |
|
For sure we can do it, I just didn't add it yet, because I'm waiting if Connor will approve the changes the way it is implemented on the PR on vscode-js-debug repo. |
Co-authored-by: Ankit Jain <[email protected]>
|
As I discussed with Larry we would like to merge it on our side and hope to get the merge on VS side without any change. |
|
should we land this in main now? |
|
@thaystg what's the plan with this PR? |
|
Still waiting for the approval of the PR on vscode-js-debug repo: microsoft/vscode-js-debug#1323 |
…ionOptions # Conflicts: # src/mono/wasm/debugger/BrowserDebugProxy/MemberObjectsExplorer.cs # src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
ghost
locked as resolved and limited conversation to collaborators
5 participants
To support receiving EvaluationOptions from dap.
Then we will be able to auto evaluate properties or not based on what is defined on VS settings.
https://user-images.githubusercontent.com/4503299/176544439-3ae898e5-4eb6-4883-bd57-a277fb19ff30.mp4
Depends on:
microsoft/vscode-js-debug#1323
With this check disabled:
With this check enabled:
Fixes #49144