Skip to content

#37093 disable Reciprocal test only for Android x86#71541

Merged
mkhamoyan merged 2 commits intodotnet:mainfrom
mkhamoyan:37093_disable_androidx86
Jul 7, 2022
Merged

#37093 disable Reciprocal test only for Android x86#71541
mkhamoyan merged 2 commits intodotnet:mainfrom
mkhamoyan:37093_disable_androidx86

Conversation

@mkhamoyan
Copy link
Contributor

@mkhamoyan mkhamoyan commented Jul 1, 2022

Disable Reciprocal test only for Android x86 #37093

@ghost ghost added the area-System.Numerics label Jul 1, 2022
@ghost ghost assigned mkhamoyan Jul 1, 2022
@ghost
Copy link

ghost commented Jul 1, 2022

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mkhamoyan
Assignees: -
Labels:

area-System.Numerics

Milestone: -

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan mkhamoyan requested a review from steveisok July 1, 2022 14:39
@tannergooding
Copy link
Member

Do we know why Android has so many differences here?

I don't believe we're seeing the same on x86, x64, Arm32, Arm64, s390X, PPC, or iOS.

@mkhamoyan
Copy link
Contributor Author

Do we know why Android has so many differences here?

I don't believe we're seeing the same on x86, x64, Arm32, Arm64, s390X, PPC, or iOS.

In Android x86 operations for double don't work as expected. For now we are disabling these test only for x86 android until we will fix the issue.

@tannergooding
Copy link
Member

Do we know why Android x86 behaves differently for doubles?

Is it perhaps using the legacy x87 FPU still and is misconfigured to 80-bit rounding rather than 64-bit rounding?

I had thought a PR existed to ensure Mono always uses SSE/SSE2 on x86, since it's a 20+ year old hardware baseline at this point (and required for all x64 chips) but perhaps that hasn't been merged yet or was missed for Android?

@mkhamoyan
Copy link
Contributor Author

Do we know why Android x86 behaves differently for doubles?

Is it perhaps using the legacy x87 FPU still and is misconfigured to 80-bit rounding rather than 64-bit rounding?

I had thought a PR existed to ensure Mono always uses SSE/SSE2 on x86, since it's a 20+ year old hardware baseline at this point (and required for all x64 chips) but perhaps that hasn't been merged yet or was missed for Android?

@steveisok maybe you know about that PR ?

@tannergooding
Copy link
Member

Looks to have not been merged yet: #65723

This might be part of the Android x86 issue, although I'd guess there is another part at play (perhaps fpu configuration) since regular x86 isn't seeing the same.

@mkhamoyan
Copy link
Contributor Author

I will merge this PR and once #65723 will be merged I will enable all disabled tests related to it.

@mkhamoyan mkhamoyan merged commit 8803e61 into dotnet:main Jul 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
@mkhamoyan mkhamoyan deleted the 37093_disable_androidx86 branch August 19, 2022 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants