[wasm] Wasm.Build.Tests: Use Chrome on windows, instead of V8#72983
Merged
pavelsavara merged 2 commits intodotnet:mainfrom Jul 28, 2022
Merged
[wasm] Wasm.Build.Tests: Use Chrome on windows, instead of V8#72983pavelsavara merged 2 commits intodotnet:mainfrom
pavelsavara merged 2 commits intodotnet:mainfrom
Conversation
ghost
assigned
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
radical
force-pushed
the
wbt-v8-to-chrome
branch
from
4a27b93 to
628cd40
Compare
radical
force-pushed
the
wbt-v8-to-chrome
branch
from
628cd40 to
09e497e
Compare
pavelsavara
approved these changes
Jul 28, 2022
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 has issues running on windows, and that's not really something we support anyway. So, switch to using Chrome for running Wasm.Build.Tests, same as we do for library tests.
Fixes #72880 .