Refactor input bubble checks to work in non-composite scenarios#73350
Merged
davidwrighton merged 3 commits intodotnet:mainfrom Aug 8, 2022
Conversation
- Input bubble checks for making sure that the input bubble is valid are not currently processed for non-composite scenarios - Refactor them so that they are not n^2 in cost, and are handled for both composite and non-composite scenarios
trylek
reviewed
Aug 6, 2022
|
|
||
| static LPCUTF8 GetKey(const SimpleNameToExpectedMVIDAndRequiringAssembly& e) { return e.SimpleName; } | ||
|
|
||
| static BOOL Equals(LPCUTF8 a, LPCUTF8 b) { return strcmp(a, b) == 0; } // Use a case senstive comparison here even though |
Member
There was a problem hiding this comment.
Nit - typo (senstive -> sensitive)
trylek
approved these changes
Aug 6, 2022
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Beautiful optimization and general improvement, thank you!
ghost
locked as resolved and limited conversation to collaborators
davidwrighton
deleted the
refactor_inputbubble_checks_to_work_in_non_composite_scenarios
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71131