Update for recent compiler changes for ref fields#73466
Merged
AaronRobinsonMSFT merged 5 commits intodotnet:mainfrom Aug 13, 2022
Merged
Update for recent compiler changes for ref fields#73466AaronRobinsonMSFT merged 5 commits intodotnet:mainfrom
AaronRobinsonMSFT merged 5 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsSee dotnet/roslyn#62886.
|
Member
|
Are all of these changes necessary in order to successfully compile? If yes, this seems like a fairly significant breaking change, no? Or are these changes only necessary because of related places we're already using scoped? |
jaredpar
reviewed
Aug 5, 2022
...m.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IDictionaryConverter.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
Yes, these are changes needed to compile successfully. These are typically methods that have a |
stephentoub
reviewed
Aug 5, 2022
| internal override bool CanHaveMetadata => false; | ||
|
|
||
| protected override void Add(in TElement value, ref ReadStack state) | ||
| protected override void Add(in TElement value, scoped ref ReadStack state) |
Member
There was a problem hiding this comment.
Why is scoped required here?
stephentoub
reviewed
Aug 5, 2022
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Other than the comments questioning why certain categories of changes are needed, LGTM.
This was referenced Aug 5, 2022
jaredpar
reviewed
Aug 11, 2022
| where TCollection : ConcurrentQueue<TElement> | ||
| { | ||
| protected override void Add(in TElement value, ref ReadStack state) | ||
| protected override void Add(in TElement value, scoped ref ReadStack state) |
jaredpar
reviewed
Aug 11, 2022
| where TKey : notnull | ||
| { | ||
| protected override void Add(TKey key, in TValue value, JsonSerializerOptions options, ref ReadStack state) | ||
| protected override void Add(TKey key, in TValue value, JsonSerializerOptions options, scoped ref ReadStack state) |
jaredpar
reviewed
Aug 11, 2022
| private readonly bool _isDeserializable = typeof(TCollection).IsAssignableFrom(typeof(List<object?>)); | ||
|
|
||
| protected override void Add(in object? value, ref ReadStack state) | ||
| protected override void Add(in object? value, scoped ref ReadStack state) |
jaredpar
reviewed
Aug 11, 2022
| private readonly bool _isDeserializable = typeof(TCollection).IsAssignableFrom(typeof(List<TElement>)); | ||
|
|
||
| protected override void Add(in TElement value, ref ReadStack state) | ||
| protected override void Add(in TElement value, scoped ref ReadStack state) |
jaredpar
reviewed
Aug 11, 2022
| where TCollection : ConcurrentStack<TElement> | ||
| { | ||
| protected override void Add(in TElement value, ref ReadStack state) | ||
| protected override void Add(in TElement value, scoped ref ReadStack state) |
jaredpar
approved these changes
Aug 11, 2022
Member
|
I don't see any failures in the arm64 test. Looks like an infrastructure issue. [15:05:31.5263400] 2022-08-12 15:05:31.506 System.Runtime.Tests[16226:178107346] Tests run: 49815 Passed: 49582 Inconclusive: 0 Failed: 0 Ignored: 137 Skipped: 96 |
AaronRobinsonMSFT
approved these changes
Aug 13, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dotnet/roslyn#62886.