Improve IndexOf(char, OrdinalIgnoreCase)#73533
Merged
EgorBo merged 2 commits intodotnet:mainfrom Aug 8, 2022
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
…ng.cs Co-authored-by: Stephen Toub <[email protected]>
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsA similar trick is used for Benchmark: using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher.FromAssembly(typeof(Benchmarks).Assembly).Run(args);
public class Benchmarks
{
const string TestStr =
".NET Runtime uses third-party libraries or other resources that may be" +
" distributed under licenses different than the.NET Runtime software.";
[Benchmark]
public int IndexOfDash() => TestStr.IndexOf('-', StringComparison.OrdinalIgnoreCase);
[Benchmark]
public int IndexOfL() => TestStr.IndexOf('L', StringComparison.OrdinalIgnoreCase);
[Benchmark]
public int IndexOfZ() => TestStr.IndexOf('z', StringComparison.OrdinalIgnoreCase);
}
|
Member
Author
|
Failure is #73247 |
This was referenced Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A similar trick is used for
IndexOf(string, OrdinalIgnoreCase)see here.Benchmark: