unify error handling for FileStream and Pipe Streams#77543
Merged
adamsitnik merged 7 commits intodotnet:mainfrom Nov 8, 2022
Merged
unify error handling for FileStream and Pipe Streams#77543adamsitnik merged 7 commits intodotnet:mainfrom
adamsitnik merged 7 commits intodotnet:mainfrom
Conversation
…ientStream.Read* methods
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsTODO:
|
adamsitnik
changed the title
stephentoub
reviewed
Oct 28, 2022
| public static class UnifiedErrorHandlingTests | ||
| { | ||
| [Fact] | ||
| public static void WhenAnonymousPipeServerIsClosedAnonymousPipeClientReadReturnsZero() |
Member
There was a problem hiding this comment.
Nit:
I'm finding it very difficult to read and tell apart all of these different test names, including pulling out the salient details. Can you restructure them to a form something along the lines of:
AnonymousPipeServer_AnonymousPipeClient_ServerClosed_ReadReturnsZero
AnonymousPipeServer_FileStreamClient_ServerClosed_ReadReturnsZero
NamedPipeServer_FileStreamClient_ServerDisconnects_ReadReturnsZero
...
etc.?
Member
Author
There was a problem hiding this comment.
@stephentoub can we meet somewhere in the middle?
- WhenAnonymousPipeServerIsClosedAnonymousPipeClientReadReturnsZero
+ When_AnonymousPipeServer_IsClosed_AnonymousPipeClient_ReadReturnsZeroSince we are using the [Fact] to annotate the tests I am trying to name in the way that they describe the fact they are testing.
stephentoub
reviewed
Oct 28, 2022
src/libraries/System.IO.Pipes/tests/UnifiedErrorHandlingTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 28, 2022
src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs
Show resolved
Hide resolved
stephentoub
reviewed
Oct 28, 2022
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/FileStreamHelpers.Windows.cs
Show resolved
Hide resolved
stephentoub
reviewed
Oct 28, 2022
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/FileStreamHelpers.Windows.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Nov 7, 2022
Member
Author
|
The test failures are unrelated (#78017), merging. |
Member
Author
|
@stephentoub thank you for the review! We are one step closer to PipeStream and File Stream code unification (preferably reuse) |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
FileStreamto matchAnonymousPipe*Stream,NamedPipe*Streamedge case error handling. Namely:FileStreamfails with an exception rather than reporting success and writing nothing (what we had so far).FileStreamreturns zero rather than throwing an exception (what we had so far).