Use ArgumentOutOfRangeException.Throw helpers in more places#79460
Merged
stephentoub merged 4 commits intodotnet:mainfrom Dec 11, 2022
Merged
Use ArgumentOutOfRangeException.Throw helpers in more places#79460stephentoub merged 4 commits intodotnet:mainfrom
stephentoub merged 4 commits intodotnet:mainfrom
Conversation
stephentoub
requested review from
MichalStrehovsky and
marek-safar
as code owners
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsI ran the new analyzer and auto-fixed all the occurrences. However, the analyzer is also conservative and won't flag throws that are using a customized message, so I also searched for some messages known to not provide any additional useful information and replaced those call sites. There are still more cases that can be evaluated subsequently.
|
stephentoub
force-pushed
the
moreaoorethrow
branch
from
07f73d0 to
bd9e4a3
Compare
MihaZupan
approved these changes
Dec 10, 2022
src/libraries/System.Private.CoreLib/src/System/Collections/Generic/HashSet.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/IO/UnmanagedMemoryAccessor.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/JulianCalendar.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Principal.Windows/src/Resources/Strings.resx
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <[email protected]>
Member
Author
|
/azp list |
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the new analyzer and auto-fixed all the occurrences.
However, the analyzer is also conservative and won't flag throws that are using a customized message, so I also searched for some messages known to not provide any additional useful information and replaced those call sites.
There are still more cases that can be evaluated subsequently.