Merged
Conversation
ghost
added
area-NativeAOT-coreclr
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Detailsfixes #79802 Is there any particular reason to use
|
MichalStrehovsky
approved these changes
Dec 28, 2022
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Thank you!
Is there any particular reason to use
XDocument.XPathNavigatorinstead of using much nicer XDocument APIs directly?
We keep this implementation very close (ideally line-by-line) to how this works in IL Linker. The decision was made there...
Member
|
Cc @dotnet/ilc-contrib more unification with illinker |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #79802
Is there any particular reason to use
XDocument.XPathNavigatorinstead of using much nicer XDocument APIs directly?cc @MichalStrehovsky