[build] Use MonoWasmBuildVariant to select runtime variant#80024
Conversation
lambdageek
requested review from
lewing,
marek-safar,
pavelsavara and
radical
as code owners
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsUse Note that this is distinct from what users do: the public The only tricky bit is that when building and testing the sample projects, we need to set the public properties, not the wasm build variant property. Fixes #75152
|
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maraf
left a comment
maraf
left a comment
There was a problem hiding this comment.
LGTM,
I'm just thinking whether MonoWasmRuntimeVariant wouldn't be a better name?
We can consider changing in a follow-up PR. ( |
|
I'm going to pick up the changes in |
Use `MonoWasmBuildVariant=multithread` and `MonoWasmBuildVariant=perftrace` consistently to select the runtime variant. Previously we also supported setting `WasmEnableThreads` or `WasmEnablePerfTracing` to configure the runtime variant. This PR removes support for that. Note that this is distinct from what users do: the public `WasmEnableThreads` (respectively, `WasmEnablePerfTracing`) property are used in user project to choose the threaded (respectively, diagnostic tracing) runtime pack in a user project. That support is not going way in this PR. The only tricky bit is that when building and testing the sample projects, we need to set the public properties, not the wasm build variant property. Fixes dotnet#75152
lambdageek
force-pushed
the
prefer-WasmBuildVariant-over-WasmEnable
branch
from
bc8b531 to
ebd2ba7
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
2 participants
Use
MonoWasmBuildVariant=multithreadandMonoWasmBuildVariant=perftraceconsistently to select the runtime variant. Previously we also supported settingWasmEnableThreadsorWasmEnablePerfTracingto configure the runtime variant. This PR removes support for that.Note that this is distinct from what users do: the public
WasmEnableThreads(respectively,WasmEnablePerfTracing) property are used in user project to choose the threaded (respectively, diagnostic tracing) runtime pack in a user project. That support is not going way in this PR.The only tricky bit is that when building and testing the sample projects, we need to set the public properties, not the wasm build variant property.
Fixes #75152