Skip to content

Fix nullable annotations in ITypedList#80033

Merged
stephentoub merged 1 commit intodotnet:mainfrom
gpetrou:FixITypedList
Jan 8, 2023
Merged

Fix nullable annotations in ITypedList#80033
stephentoub merged 1 commit intodotnet:mainfrom
gpetrou:FixITypedList

Conversation

@gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Dec 29, 2022

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.ComponentModel new-api-needs-documentation labels Dec 29, 2022
@ghost
Copy link

ghost commented Dec 29, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Dec 29, 2022

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

Issue Details

According to:
https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.itypedlist.getitemproperties
https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.itypedlist.getlistname
the parameters can be null.
I bumped into this problem while annotating ListBindingHelper in WinForms repository.
https://github.com/dotnet/winforms/blob/bc73fc2790fdce8ac7399eddf76824161bdd35cc/src/System.Windows.Forms/src/System/Windows/Forms/ListBindingHelper.cs

Author: gpetrou
Assignees: -
Labels:

area-System.ComponentModel, new-api-needs-documentation, community-contribution
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Dec 29, 2022
Closed
stephentoub
stephentoub approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@stephentoub stephentoub merged commit 339a204 into dotnet:main Jan 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-System.ComponentModel community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gpetrou @stephentoub @buyaa-n