Ignore SendMessageTimeout failures on Windows Nano Server#80099
Merged
jkotas merged 2 commits intodotnet:mainfrom Jan 3, 2023
Merged
Ignore SendMessageTimeout failures on Windows Nano Server#80099jkotas merged 2 commits intodotnet:mainfrom
jkotas merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danmoseley
approved these changes
Jan 2, 2023
| || (PlatformDetection.IsWindows && PlatformDetection.IsPrivilegedProcess); | ||
|
|
||
| // [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")] | ||
| if (PlatformDetection.IsWindowsNanoServer && target == EnvironmentVariableTarget.User) |
Member
There was a problem hiding this comment.
I guess this has to stay in SetEnvironmentVariable?
Member
There was a problem hiding this comment.
actually I think that should be removed
Member
There was a problem hiding this comment.
Hmm, I thought setting per-user env vars worked, but only for the current process. So these two tests ought to pass, as it's all in the same process. You've made them skip though?
danmoseley
reviewed
Jan 2, 2023
This was referenced Jan 2, 2023
Closed
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
NativeAOT_Libs failures are #79453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30566