[wasm] Make WasmMainJSPath optional#81484
Merged
maraf merged 28 commits intodotnet:mainfrom Feb 27, 2023
Merged
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # src/mono/sample/wasi/Directory.Build.targets # src/mono/sample/wasm/Directory.Build.targets # src/mono/sample/wasm/browser/Wasm.Browser.Sample.csproj # src/mono/sample/wasm/console-v8/Wasm.Console.V8.Sample.csproj
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Failure is unrelated |
pavelsavara
reviewed
Feb 16, 2023
pavelsavara
reviewed
Feb 16, 2023
pavelsavara
reviewed
Feb 16, 2023
pavelsavara
approved these changes
Feb 16, 2023
Member
There was a problem hiding this comment.
Minor comments but LGTM. It would be good to hear from @radical
radical
previously requested changes
Feb 22, 2023
ghost
added
needs-author-action
Member
Author
|
/azp run runtime |
|
Pull request contains merge conflicts. |
# Conflicts: # src/tasks/WasmAppBuilder/WasmAppBuilder.cs
radical
reviewed
Feb 23, 2023
|
|
||
| <ItemGroup> | ||
| <WasmExtraFilesToDeploy Include="index.html" /> | ||
| <WasmExtraFilesToDeploy Include="main.js" /> |
Member
There was a problem hiding this comment.
Adding these in the various places outside the wasm targets can be dropped now.
radical
approved these changes
Feb 23, 2023
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
Other than the one comment, LGTM! Good job 👍
Member
|
@maraf I resolved the merge conflicts. Hopefully, I didn't break anything! |
5 tasks
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WasmMainJSPathrequired only for console targets (v8/node).WasmMainJSPathfrom browser projects.Closes #63465