Disable EnsureCleanEnvironment on wasm since it can't possibly work#81893
Merged
kg merged 1 commit intodotnet:mainfrom Feb 9, 2023
Merged
Disable EnsureCleanEnvironment on wasm since it can't possibly work#81893kg merged 1 commit intodotnet:mainfrom
kg merged 1 commit intodotnet:mainfrom
Conversation
kg
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis previous test failure https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-81811-merge-d89ce95366874b81b8/PayloadGroup0/1/console.969b1dd5.log?helixlogtype=result appears to be the result of test scaffolding relying on System.Diagnostics.Process on all non-Windows OSes, including WASM (which doesn't have processes). The scaffolding appears to be trying to clean up persistent state that doesn't exist in the WASM environment, so it seems appropriate to just disable the method on WASM. cc @mdh1418
|
mdh1418
approved these changes
Feb 9, 2023
radical
approved these changes
Feb 9, 2023
Member
|
related - the test is skipped on CI now - #81860 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This previous test failure https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-81811-merge-d89ce95366874b81b8/PayloadGroup0/1/console.969b1dd5.log?helixlogtype=result appears to be the result of test scaffolding relying on System.Diagnostics.Process on all non-Windows OSes, including WASM (which doesn't have processes). The scaffolding appears to be trying to clean up persistent state that doesn't exist in the WASM environment, so it seems appropriate to just disable the method on WASM.
cc @mdh1418