Skip to content

Implement JsonSerializerOptions.TypeInfoResolverChain.#83358

Merged
eiriktsarpalis merged 6 commits intodotnet:mainfrom
eiriktsarpalis:feature/typeinforesolverschain
Mar 15, 2023
Merged

Implement JsonSerializerOptions.TypeInfoResolverChain.#83358
eiriktsarpalis merged 6 commits intodotnet:mainfrom
eiriktsarpalis:feature/typeinforesolverschain

Conversation

@eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Mar 13, 2023

Fix #83095.

cc @eerhardt

@ghost
Copy link

ghost commented Mar 13, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned eiriktsarpalis Mar 13, 2023
@eiriktsarpalis eiriktsarpalis requested review from layomia and removed request for stephentoub March 13, 2023 22:43
@ghost
Copy link

ghost commented Mar 13, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #83095.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

@eiriktsarpalis eiriktsarpalis assigned tarekgh and unassigned tarekgh Mar 13, 2023
@eiriktsarpalis eiriktsarpalis requested a review from tarekgh March 13, 2023 22:43
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Mar 13, 2023
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let @layomia or @krwq comment if they have any more feedback.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JsonSerializerOptions should provide explicit control over chained IJsonTypeInfoResolvers

4 participants