Add a JsonSerializerOptions.TryGetTypeInfo method.#84411
Merged
eiriktsarpalis merged 2 commits intodotnet:mainfrom Apr 12, 2023
Merged
Add a JsonSerializerOptions.TryGetTypeInfo method.#84411eiriktsarpalis merged 2 commits intodotnet:mainfrom
JsonSerializerOptions.TryGetTypeInfo method.#84411eiriktsarpalis merged 2 commits intodotnet:mainfrom
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
eiriktsarpalis
requested review from
krwq and
layomia
and removed request for
layomia
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #81269.
|
eiriktsarpalis
added
the
breaking-change
ghost
added
the
needs-breaking-change-doc-created
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
eiriktsarpalis
commented
Apr 6, 2023
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
Show resolved
Hide resolved
tarekgh
approved these changes
Apr 6, 2023
eiriktsarpalis
added
the
NO-MERGE
Member
Author
|
Let's hold off from merging this until aspnetcore can react to the changes. |
eerhardt
reviewed
Apr 6, 2023
src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs
Show resolved
Hide resolved
Sergio0694
reviewed
Apr 6, 2023
eiriktsarpalis
removed
the
NO-MERGE
eiriktsarpalis
changed the title
JsonSerializerOptions.TryGetTypeInfo method.
eiriktsarpalis
removed
breaking-change
Member
Author
|
Per #81269 (comment) I've updated the PR so that it introduces a new |
3 tasks
ghost
locked as resolved and limited conversation to collaborators
eiriktsarpalis
added
the
size-reduction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #81269.